Module 2: Day 2 Peer to Peer Code Review

souad988 / S-EL-DevSchool

This is the first capstone project from microverse. this project is a website for web developement schools, were students can see new courses info programs and teachers . built using html/css and javascript

https://souad988.github.io/S-EL-DevSchool/

7 stars 1 forks source link

Module 2: Day 2 Peer to Peer Code Review #3

Open mnekx opened 2 years ago

mnekx commented 2 years ago

DRY For the Navigation

-navigation menu could be done with one markup eg just the desktop and hide the respective one on a particular screen

-Good job on the 'MORE' and 'LESS' buttons they are truly dynamic even when the list changes

zmekonnen251 commented 2 years ago

You did an amazing job. your work is near to perfection, But I got one thing to say. even if the logo is used to take the user to the home page there must be a home button in the navbar of the about page.

Tufahel commented 2 years ago

Your project is good. The interface is eye-catchy. The color Transition of the header title is also looking nice. Javascript integration is also working absolutely fine. Here is some suggestion from me that you may consider

The mobile menu should have an (X) button to close menu details.
Background image of the header section should not be repeated.
Footer text of the about page of the desktop version should not be dark.