Peer to peer code review

souad988 / ToDoList

this project is a web application where users can add new tasks to their todolist, mark a task as done, update it or remove it, and can also clear all completed tasks in one click , this project is built using html/css and javascript.

https://souad988.github.io/ToDoList

3 stars 0 forks source link

Peer to peer code review #5

Open brahimdidi opened 2 years ago

brahimdidi commented 2 years ago

Hello Ismail and souad, great work on your project however we would like to point out some points.

You did not follow the AAA (arrange, act, assert), It would be better if you implement that.
On this line https://github.com/souad988/ToDoList/blob/6dcc1857ac5472478bb72f0caa966ea75f2ec002/src/modules/crud.test.js#L18 the title is wrong.
The index.test.js file is not testing the dom manipulation

ahangarha commented 2 years ago

I also wanted to ask why you implemented localStorage mock? The the project specification it was said we need to mock localStorage on Ject version 25 and below. No?