search

souffle-lang / souffle

Soufflé is a variant of Datalog for tool designers crafting analyses in Horn clauses. Soufflé synthesizes a native parallel C++ program from a logic specification.
http://souffle-lang.github.io/
Universal Permissive License v1.0
913 stars 206 forks source link

Fix some clang tidy warnings #2464

Open Xazax-hun opened 9 months ago

Xazax-hun commented 9 months ago

Mostly adding noexcept to some move assignments/ctors so they are utilized by STL. Also adding some std::move calls to avoid certain potentially expensive copies. Some misc fixes/improvements including fixing typos in comments.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (9ac6b24) 78.18% compared to head (8016caa) 78.21%. Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464/graphs/tree.svg?width=650&height=150&src=pr&token=uyaWjuodpY&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang)](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang) ```diff @@ Coverage Diff @@ ## master #2464 +/- ## ========================================== + Coverage 78.18% 78.21% +0.02% ========================================== Files 486 486 Lines 32422 32420 -2 ========================================== + Hits 25349 25357 +8 + Misses 7073 7063 -10 ``` | [Files](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang) | Coverage Δ | | |---|---|---| | [src/ast/Constraint.h](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang#diff-c3JjL2FzdC9Db25zdHJhaW50Lmg=) | `100.00% <100.00%> (ø)` | | | [src/ast/Lattice.h](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang#diff-c3JjL2FzdC9MYXR0aWNlLmg=) | `100.00% <ø> (ø)` | | | [src/ast/Literal.h](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang#diff-c3JjL2FzdC9MaXRlcmFsLmg=) | `100.00% <100.00%> (ø)` | | | [src/ast/UnnamedVariable.cpp](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang#diff-c3JjL2FzdC9Vbm5hbWVkVmFyaWFibGUuY3Bw) | `100.00% <100.00%> (ø)` | | | [src/ast/UserDefinedAggregator.cpp](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang#diff-c3JjL2FzdC9Vc2VyRGVmaW5lZEFnZ3JlZ2F0b3IuY3Bw) | `96.29% <100.00%> (ø)` | | | [src/ast/analysis/Aggregate.cpp](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang#diff-c3JjL2FzdC9hbmFseXNpcy9BZ2dyZWdhdGUuY3Bw) | `99.26% <100.00%> (-0.02%)` | :arrow_down: | | [src/ast/analysis/typesystem/TypeSystem.h](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang#diff-c3JjL2FzdC9hbmFseXNpcy90eXBlc3lzdGVtL1R5cGVTeXN0ZW0uaA==) | `86.01% <100.00%> (ø)` | | | [src/ast2ram/utility/ValueIndex.cpp](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang#diff-c3JjL2FzdDJyYW0vdXRpbGl0eS9WYWx1ZUluZGV4LmNwcA==) | `76.92% <100.00%> (ø)` | | | [src/include/souffle/RecordTable.h](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang#diff-c3JjL2luY2x1ZGUvc291ZmZsZS9SZWNvcmRUYWJsZS5o) | `100.00% <100.00%> (ø)` | | | [src/include/souffle/datastructure/BTree.h](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang#diff-c3JjL2luY2x1ZGUvc291ZmZsZS9kYXRhc3RydWN0dXJlL0JUcmVlLmg=) | `98.12% <100.00%> (ø)` | | | ... and [38 more](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/souffle-lang/souffle/pull/2464/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=souffle-lang)