search

sougatamondal / migratordotnet

Automatically exported from code.google.com/p/migratordotnet
0 stars 0 forks source link

Create Table Doesn't if we use columns with reserved keywords (e.g. Order) #171

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Create a Migation with a column named Order
2. Run the migation

What is the expected output? What do you see instead?
It should just escape the column name so the script doesnt crash

What version of the product are you using? On what operating system? With what 
.NET implementation/version?
Lates on the latest with the latest. 

What database and version are you seeing this issue on?
SQL Server 2008

Please provide any additional information below.
I provided an example. 

Fixes
If on the Create table script I pass "[Order]" as the column name it works 
fine. However this is inconsistent with other methods. If I call RenameColumn 
and name it "[Order]" it actually creates a column that includes the square 
brackets instead of a column name "Order". Rename column uses sp_rename which 
already handles this. 

Maybe the best thing isn't to use reserved keyworks for column name. However, 
since this is something supported by most DBs I think MigratorDotNet should 
support this. 

Quick fix would be to always add the square brackets to every column when 
creating a new column.

Original issue reported on code.google.com by ICantFin...@gmail.com on 4 Mar 2011 at 3:54

Attachments: