sougatamondal / migratordotnet

Automatically exported from code.google.com/p/migratordotnet
0 stars 0 forks source link

Latest build breaks Rename/Remove columns if you fully qualify table names #78

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. create a migration to add a column [Bar] to table [Foo].[SomeTable]
2. add a 2nd migration to rename [Bar] to [Baz] on table [Foo].[SomeTable]

What is the expected output? What do you see instead?
our existing migrations failed on the latest version because of this error 
(it failed silently)

What database and version are you seeing this issue on?
SqlServer

Patch is attached.  It adds support for specifying fully qualified table 
names when calling RenameColumn & RemoveColumn.

Brackets ([]) are stripped out and schema is added to the 
information_schema queries (when appropriate).

It also now throws an exception if it fails to rename a column, since that 
affects subsequent migrations.

Original issue reported on code.google.com by subdigi...@gmail.com on 27 Oct 2008 at 4:54

Attachments:

GoogleCodeExporter commented 8 years ago
Totally valid issue, but this patch only fixes SQL Server. This might be an 
issue 
with other databases as well and it would probably be best if we could figure 
out a 
way to fix it for all of them at once if possible?

Original comment by geoffl...@gmail.com on 22 Dec 2008 at 5:23

GoogleCodeExporter commented 8 years ago
Hi all,
Having this issue solved we can handle column/table names containing spaces 
(which
currently we can't). 
Therefore I don't think this is an enhancement at all (let me know if you agree 
with
this). I would raise the priority though.
Regards.

Original comment by benjamin...@gmail.com on 26 Jan 2009 at 12:03

GoogleCodeExporter commented 8 years ago
I guess if we can fix this issue for all supported databases then it could be 
applied  
no problem.

Original comment by subdigi...@gmail.com on 26 Jan 2009 at 6:13