search

soul4soul / ot-monster-converter

C# .NET 5 program for converting OpenTibia (OT) monsters between commonly used formats
10 stars 12 forks source link

Suggestion to empty nameDescription="" #72

Closed EPuncker closed 2 years ago

EPuncker commented 2 years ago

A few monsters aren't coming with nameDescription="" filled, so what about filling it with name but lowercase, or same as name if boss=true

edit, same for race, what about making it blood for everyone until we have proper info at wiki?

soul4soul commented 2 years ago

A few monsters aren't coming with nameDescription="" filled, so what about filling it with name but lowercase, or same as name if boss=true

I had the bright idea to generate the article a/an based on the name of the monster but it turns out its not that simple and the rule uses the sound of the word and not the spelling of the word. https://stackoverflow.com/questions/1288291/how-can-i-correctly-prefix-a-word-with-a-and-an Setting it as the name for bosses makes sense, is it true for all bosses that the nameDescription is the same as the name?

edit, same for race, what about making it blood for everyone until we have proper info at wiki?

Blood should be default. I forgot to print out the blood type when generating TFS XML monsters. I made the function GenerictoTfsBlood but its never called. It needs to be added at https://github.com/soul4soul/ot-monster-converter/blob/master/app/MonsterConverterTfsXml/TfsXmlConverter.cs#L367-L368

EPuncker commented 2 years ago

is it true for all bosses that the nameDescription is the same as the name?

of all these years of editing files and looking for information, I'm 99% sure all of them are