search

soulcutter / saxerator

A SAX-based XML parser for parsing large files into manageable chunks
MIT License
128 stars 19 forks source link

Ignore namespace bugfix #10

Closed quoideneuf closed 10 years ago

quoideneuf commented 10 years ago

It turns out that rerouting start_element_namespace to start_element was not a good idea. If the tag has attributes, the accumulator will raise a Hash argument exception. I reworked things so that the method chain stays the same, and prefixes and uris are just forced into nil if @ignore_namespaces is present.

Sorry I didn't catch these earlier.

soulcutter commented 10 years ago

No worries, I didn't catch that either! Thanks for the fix

quoideneuf commented 10 years ago

Thanks again for pushing a new release. It looks like we're back in business.