Add attributes in empty tags

soulcutter / saxerator

A SAX-based XML parser for parsing large files into manageable chunks

MIT License

128 stars 19 forks source link

Add attributes in empty tags #18

Closed leifg closed 10 years ago

leifg commented 10 years ago

This is a quick fix for the problem in #17.

The main problem here though is, that tags with attributes and no children are handled as EmptyElement. If you change the handling of EmptyElements (merge attributes in it) existing tests break.

So I don't really know how to fix this on a global level. I guess the term "Empty Element" needs to be better defined

soulcutter commented 10 years ago

Thanks for taking the time to dig into this. EmptyElement is a bit weird… hmm… well, I shouldn't hold this up any longer since it's been hanging out for so long.