Attributes should respect symbolize_key config

soulcutter / saxerator

A SAX-based XML parser for parsing large files into manageable chunks

MIT License

128 stars 19 forks source link

Attributes should respect symbolize_key config #23

Closed doomspork closed 9 years ago

doomspork commented 9 years ago

@soulcutter would love to get your thoughts on these changes which should close issue #20, I also added a few other specs I did not see. The version has been bumped to 0.9.5.

soulcutter commented 9 years ago

This looks great overall. I really appreciate you taking the time to add some coverage in here also! I'd be happy to merge when a couple of the small cosmetic issues are taken care of.

Thanks!

doomspork commented 9 years ago

@soulcutter thanks for taking the time to look this over, I believe I have incorporated all of your feedback.

Thanks again!

soulcutter commented 9 years ago

That was fast! I'll let Travis-ci do its business, then I'll merge and release. Thanks again for the contribution.