search

soulcutter / saxerator

A SAX-based XML parser for parsing large files into manageable chunks
MIT License
128 stars 19 forks source link

Updated configuration class for check output_type for different adapters. Cosmetic changes #35

Closed fanantoxa closed 8 years ago

fanantoxa commented 8 years ago

@soulcutter I've updated configuration class. Should fix:

disallow Saxerator::Configuration#output_type = :xml for Ox (or alternately get that to work, but that seems way harder at this point)

Take a look please when you'll find a time.

fanantoxa commented 8 years ago

@soulcutter Also updated benchmark file for test with all adapters

fanantoxa commented 8 years ago

@soulcutter Did you saw this requests ? :)

soulcutter commented 8 years ago

Yes, I am going to a hack night tomorrow and will be looking at this. Apologies for the silence, have been working very hard lately

Bradley Schaefer

On Jul 20, 2016, at 3:17 AM, fanantoxa notifications@github.com wrote:

@soulcutter Did you saw this requests ? :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

fanantoxa commented 8 years ago

@soulcutter It's ok) Waiting for your feedback)

fanantoxa commented 8 years ago

@soulcutter Maybe we can find another way for communication? Maybe skype / slack or gitter to avoid this ping questions and faster communication?

soulcutter commented 8 years ago

I'm Sou|cutter on FreeNode IRC

soulcutter commented 8 years ago

I like this, but it will need rebasing off of my ox branch and tweaked a bit for adapter specific tests based on my spec helper changes.

Thanks a ton for your contributions!

fanantoxa commented 8 years ago

@soulcutter I've added you on IRC, please let me know when you'll available I want to discuss this and few other ideas.

fanantoxa commented 8 years ago

@soulcutter I've rebased form master and updated code with your additions. Check please

fanantoxa commented 8 years ago

@soulcutter sorry can't find you on freenode, say that No such nick/channel. could you find me with nick 'fanantoxa' please ?

fanantoxa commented 8 years ago

@soulcutter fixed all additions that you've mentioned. All tests pass

soulcutter commented 8 years ago

I think we need to open this against the master branch

fanantoxa commented 8 years ago

@soulcutter I'll rebaise from master again and create new pull request to master now. I think today or tomorrow.

fanantoxa commented 8 years ago

@soulcutter I'm closing this task since I should to recreate PR