soulcutter / saxerator

A SAX-based XML parser for parsing large files into manageable chunks
MIT License
128 stars 19 forks source link

Check performance #37

Closed fanantoxa closed 7 years ago

fanantoxa commented 8 years ago

@soulcutter I've worked with ox some time and it worked better than we can see on benchmark now. Usually it parse xml in 2 .. 10 times faster. So I think we can have some performance issues here.

You can check other benchmark here: https://gist.github.com/danneu/3977120 . It's a bit old but numbers really should be like this. I'll try to update to use our xml example and compare it.

fanantoxa commented 8 years ago

@soulcutter I've found few big performance issues but It's to much to write. Could you sent me your email / skype / whetever to fanantoxa@gmail.com please? We realy have to discuss it first before I make any changes.

soulcutter commented 8 years ago

Will be reaching out to you on gmail/gchat. I suspect we may have trouble syncing up because of timezones / work hours.

fanantoxa commented 8 years ago

We have a lot of performance issues:

@soulcutter I'll added the firs list of issues and will work on that. Please take a look on (Check Configuration class for useless functionality)[https://github.com/soulcutter/saxerator/issues/42]. It's kind of road block for refactoring HashBuilder

soulcutter commented 7 years ago

I believe all of this is addressed. Let's open individual issues / PRs if we run across other wins.