added usefull rubocop config. Updated all files with the rules

soulcutter / saxerator

A SAX-based XML parser for parsing large files into manageable chunks

MIT License

128 stars 19 forks source link

added usefull rubocop config. Updated all files with the rules #40

Closed fanantoxa closed 8 years ago

fanantoxa commented 8 years ago

@soulcutter I've added config for rubocop and updated all files. Please merge it if it fit to you. If it not please let me know which rules you want to on/off and I'll update PR

soulcutter commented 8 years ago

This caught some good stuff, both in style and substance.

One cop I would like to disable is the StringLiterals cop - policing single vs double quotes is a total waste, even in an automated tool.

fanantoxa commented 8 years ago

@soulcutter I've updated rubocop config with your additions. Also I've added to this PR next tasks: Drop support ruby 1.9.3 Add a changelog

Please check when you find a time

soulcutter commented 8 years ago

Looks great!