Angular 4 or 5? - Githubissues

souldreamer / node-angular-http-client

The Angular 4.3 HttpClient for node.js

5 stars 6 forks source link

Angular 4 or 5? #2

Open Maximaximum opened 6 years ago

Maximaximum commented 6 years ago

This is just a minor documentation issue.

In the project description it says 'The Angular 4.3 HttpClient for node.js'
The readme title says 'Angular4's HttpClient for node.js'
A note inside readme says 'HttpClient taken from Angular 5.0.0-beta.5'

However, the latest version of Angular is 5.0.1, and it seems to be compatible? (at least in my use case)

Perhaps the versions declared should be consistent?

Maximaximum commented 6 years ago

BTW, there are some critical bugs in the current version of the Angular's HttpClient, for example, https://github.com/angular/angular/issues/18680. Those are also present in node-angular-http-client.

There's a PR for Angular that fixes them, and I hope that it will get merged and released soon: https://github.com/angular/angular/pull/19958

However, the same fix should be applied to this package as well.

Maximaximum commented 6 years ago

In my case it's a real show stopper 😢

ostap1010 commented 6 years ago

I am stuck with old http library because of that...

Maximaximum commented 6 years ago

Today angular version 5.0.4 has been released: https://github.com/angular/angular/blob/master/CHANGELOG.md#504-2017-12-01. It contains the fixes for the bugs that were present in provious versions of HttpClient.

Can we apply the same fixes to node-angular-http-client?

Maximaximum commented 6 years ago

I've created a PR that applies the changes that fix the empty response body bug https://github.com/souldreamer/node-angular-http-client/pull/3