soulfx / gmusic-playlist.js

a javascript version of gmusic-playlist
MIT License
114 stars 16 forks source link

Export Playlists button does nothing #10

Open jhavens12 opened 7 years ago

jhavens12 commented 7 years ago

I click the export playlists button and it closes the sidebar and brings me to the "home" page and then does nothing. Is this normal? I can open a dialogue box to import, but export does nothing.

Thanks

soulfx commented 7 years ago

google changed around the UI a little bit since this was created so I've double checked that it still works for me. when I click export it does close the sidebar, but it also still provides a file for me to download. if I re-open the sidebar it says how many songs it exported and the number of playlists.

what does the line below where it says 'Export Playlists' say after you re-open the side bar after clicking to export? for example, when I click to export it says '10062 songs. generated csv for 37 playlists'

do you have playlists available for exporting? are you subscribed to google music?

I've found it can be somewhat tricky to get this working, but once it's working it seems to do fine after that. check out some of the recommendations in the other issues. make sure you are logged into chrome as the same user you are accessing google music under, etc.

cr0ybot commented 5 years ago

Same thing happened for me, but I think I have a solution.

Some background: I am not a paying subscriber, but I use GPM for background music while I work. It's the best streaming service available for my needs: free, no ads, and plays random music based on something I like/want to listen to. I find a lot of new albums/artists I like via GPM and usually go find them on Bandcamp to buy and load onto my personal music server. Since GPM is shutting down at some point, I wanted to export all of the songs I've given a "thumbs up" to so I can find them later.

Anyways, for me the script seems to choke on line 902 (actually, line 898): Uncaught (in promise) TypeError: Cannot read property 'forEach' of undefined at genSonglists

The playlistArr variable in getPlaylists is coming back undefined, I assume since I'm not a subscriber.

So I added this at line 897: if (playlistArr == undefined) return [];

Lo and behold, the script runs and outputs a CSV for me with all of my "Thumbs"! Thanks for creating this script!

pb1051 commented 5 years ago

Great! Thanks for finding a fix!

jonathanmc commented 5 years ago

Did not do anything for me, although I'm a subscriber. Still trying to nail down a fix to the other thread about the export button doing nothing.