soulgalore / jdbcmetrics

Get information from your JDBC driver.
39 stars 12 forks source link

No JmxReporter is registered by JDBCMetrics #11

Closed rludvig closed 11 years ago

rludvig commented 11 years ago

JDBCMetrics seems to create a MetricsRegistry by using the constructor (as opposed to the static Metrics utility class). This way of instantiating the registry will not register a JMXReporter, and it doesn't seem to be possible to do it later, since the MetricsRegistry field is private.

Upon instantiating the MetricsRegistry, the following code is neede to register a JMXReporter: new JMXReporter(registry).start();

soulgalore commented 11 years ago

yes see your point, will make it possible to get the MetricsRegistry, so you can add things to it.

soulgalore commented 11 years ago

ok fixed it now, will not build a new release yet, hava a couple of things that needs to be fixed first.

soulgalore commented 11 years ago

@rludvig thanks for reporting! :)