Upgrade to Metrics 3.0.0

mwanji commented 10 years ago

Has any work been done on this? I need this now, so I'm happy to do it.

soulgalore commented 10 years ago

no nothing, yes please do if you have time, that would be great! I'm stuck on my other project sitespeed.io

mwanji commented 10 years ago

Cool.

I have a question about replacing the call to Metrics.defaultRegisry(), which no longer exists. I think the most appropriate thing to do would be to use SharedMetricRegistries.getOrCreate(String). But then the REGISTRY_PROPERTY_NAME system property should be expected to contain the name of the MetricRegistry to use, right?

Speaking of which, would it be possible to add one or both of the following options:

Set the registry name in a jdbcmetrics.properties file, as setting a system property can be a pain
Set the registry instance programmatically, which would simplify composing libraries (in my case, metrics-servlets and jdbcmetrics)

In either case, the change in behaviour of the selection of the MetricRegistry might be a breaking change.

soulgalore commented 10 years ago

well, I think there is no problem with a breaking change as long as it is documented, then we can bump the version number, so it is clear that you actually need to do a change. the two options, yes, that sounds good. So I can help out doing things, but I need to release my other project, that will probably be ready after the weekend, then we can split the workload or if you do it before.

soulgalore commented 10 years ago

fixed by @mwanji

soulgalore / jdbcmetrics

Upgrade to Metrics 3.0.0 #17