Config options not saving + lwtheme being overwritten

soulhotel / FF-ULTIMA

Native Vertical Tabs, keep your sidebar, no extensions needed. No overthinking. FF Ultima.

Mozilla Public License 2.0

298 stars 13 forks source link

Config options not saving + lwtheme being overwritten #97

Open LIlaUraraka opened 3 days ago

LIlaUraraka commented 3 days ago

Describe the bug

I am trying to configure the theme, but the options are not saving, they always get set back to default when I relaunch Firefox

Expected behavior

The setting to save their state when I toggle them

Desktop (please complete the following information):

OS: Windows 11

Browser Version: Firefox 127.0.2

Picture | Video https://imgur.com/a/AlIYGYz

soulhotel commented 3 days ago

You just need to delete the user.js file that you put into the profile folder (as per the installation instructions).

The user.js file is responsible for adding the preferences (settings) into your about:config page.

Firefox read's this file every time the browser starts up. Which will reset the preferences to their default values. So just delete that file, and your settings won't be overwritten.

Additionally:

The user.js file is a typically a one-time thing, you only need to copy/paste it when installing the theme for the first time
Or if the theme were to add new options through the about:config page. But that doesn't happen often.
Leaving the user.js file inside of the chrome folder is not an issue.

Let me know if you need further help.

soulhotel commented 3 days ago

Wait, I just noticed in your video that the theme is not applied at all.

Can you make sure your chrome folder looks like this:

2024-07-05_00-34

LIlaUraraka commented 3 days ago

I got it working! Thank you! Now one thing I noticed, the themes are not really working

soulhotel commented 3 days ago

Awesome, share a screenshot of the new issue for me please

LIlaUraraka commented 3 days ago

Here you are: https://imgur.com/a/q2J8JHz

soulhotel commented 3 days ago

This is really odd, from first glance this seems like more than a theme issue because the CSS itself doesn't contain any function that would cancel out an entire lwtheme. And I wasn't able to reproduce the issue either...

I'm guessing, there you might have some type of config/setting enabled that interferes with the theme.

Try installing the theme on a fresh profile. If the issue persist, then it is in fact the theme and I'll have to dig deeper to figure out why. If it doesn't persist on a fresh profile, then it's like I said above.

https://github.com/soulhotel/FF-ULTIMA/assets/155501797/9712a967-ebcb-4145-9806-835ad4438cfb