search

soulim / ember-cli-bootstrap-datepicker

Datepicker component for Ember CLI
http://sul.im/ember-cli-bootstrap-datepicker
MIT License
68 stars 57 forks source link

Fixes broken test introduced by #61 #84

Closed jelhan closed 8 years ago

jelhan commented 8 years ago

Test was broken since it was introduced by #61. Have to call .datepicker('update') to notify about changes.

I'm still not convinced about this test. It seems like testing bootstrap-datepicker and not this addon. But lets get a working testing suite again first.

soulim commented 8 years ago

@jelhan you rock! 😄 👍

octronic commented 8 years ago

This test was originally introduced with #35 (which solved #33)

With #63 it was refactored into an integration-test (see: https://github.com/soulim/ember-cli-bootstrap-datepicker/commit/2c0ca2f47968045c64f33107653dace298950a1b)

But this test was removed with https://github.com/soulim/ember-cli-bootstrap-datepicker/commit/7c53cf0cf9d5ef1f41a00df73b215e3ae824fa28

Long story short: my guess is #61 added this test again by accident.

soulim commented 8 years ago

Thanks for the investigation @octronic! 😉👍