search

soulim / oembed

A slim library to work with oEmbed format.
http://sul.im/oembed
MIT License
65 stars 7 forks source link

Refactoring xmlparser #4

Closed higorae closed 8 years ago

higorae commented 9 years ago

Some refactoring.

soulim commented 9 years ago

Hey @higorae! Thanks for the pull request. What was the reason behind these changes?

higorae commented 9 years ago

Hey @soulim, welcome. Do you know this project http://24pullrequests.com? I've been trying to help some opensource project like yours doing some refactoring, solving issues. =]

soulim commented 9 years ago

Yep, I know this project :smile: I can't understand what this pull request is trying to improve. What's the reason of this refactoring?