search

souliss / bindingopenhab2

Souliss binding developed for openHAB 2
3 stars 3 forks source link

T31 error in float conversion (measured and setpoint) and wrong slot #13

Open elminister83 opened 4 years ago

elminister83 commented 4 years ago

https://github.com/souliss/bindingopenhab2/blob/526e4394c11adde8979d871ea9732106e1a33249/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/internal/protocol/SoulissBindingUDPDecoder.java#L478

with this version temperature from t31 is -38,0 °C (right is 19,4)

maybe a solution is: ((SoulissT31Handler) handler).setRawStateValues(sVal, getFloatAtSlot(mac, slot + 1), getFloatAtSlot(mac, slot + 3));

fazioa commented 4 years ago

Solved with commit https://github.com/souliss/bindingopenhab2/commit/9c26d864e042ab727c3ca65d2a4d6f9848d3be39

It need testing. Let me know