search

souliss / soulissapp

SoulissApp is an Android Application for Souliss Framework
https://play.google.com/store/apps/details?id=it.angelic.soulissclient
MIT License
33 stars 33 forks source link

T12 OFF [AUTO] is shown as ON #134

Closed ribico closed 7 years ago

ribico commented 8 years ago

A T12 slot in state OFF [AUTO] is detected as state ON by SApp. In the slot view the light is lighted and the graph is counting the "on time" as it would be on (but it is not).

shineangelic commented 7 years ago

Are these correct?

        public static final short Souliss_T1n_OnCoil = 0x01;
        public static final short Souliss_T1n_OffCoil = 0x00;
        public static final short Souliss_T1n_OnCoil_Auto = 0xF1;
        public static final short Souliss_T1n_OffCoil_Auto = 0xF0;
ribico commented 7 years ago

I think yes. F0 stands for auto mode ON but coil OFF.. so AUTO (OFF)

Il mer 1 feb 2017, 00:08 Alessandro Del Pex notifications@github.com ha scritto:

Are these correct?

    public static final short Souliss_T1n_OnCoil = 0x01;
    public static final short Souliss_T1n_OffCoil = 0x00;
    public static final short Souliss_T1n_OnCoil_Auto = 0xF1;
    public static final short Souliss_T1n_OffCoil_Auto = 0xF0;

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/souliss/soulissapp/issues/134#issuecomment-276523197, or mute the thread https://github.com/notifications/unsubscribe-auth/AFiwb7PggnvgfzWk_Vl-4XnJ937tJzgLks5rX772gaJpZM4ImSor .

--

Gabriele Ribichini mob. +39 329 1920851

shineangelic commented 7 years ago

Uffff i imagined they were correct, bug must be elsewhere...

Can you replicate it on demo environment? You are saying that a 0xF0 is reported as "on", correct?

ribico commented 7 years ago

Yes, try with slot 1 of the demo environment. The lamp is shown as ON when the slot is supposed to be in AUTO OFF.

Il mer 1 feb 2017, 18:24 Alessandro Del Pex notifications@github.com ha scritto:

Uffff i imagined they were correct, bug must be elsewhere...

Can you replicate it on demo environment? You are saying that a 0xF0 is reported as "on", correct?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/souliss/soulissapp/issues/134#issuecomment-276721894, or mute the thread https://github.com/notifications/unsubscribe-auth/AFiwb2ZwoPKqwap6XcSw_NRhoMZniigPks5rYL_QgaJpZM4ImSor .

--

Gabriele Ribichini mob. +39 329 1920851

shineangelic commented 7 years ago

As I can understand from demo, T12 status is represented correctly. The problem seems to rely on the command sent:

if off > press ON > goes to ON (OK) if on > press OFF > goes to OFF (OK) if off > press AUTO > goes to OFF AUTO (OK) if on > press AUTO > gouse to OFF AUTO (NOT OK)

do you agree ?

plinioseniore commented 7 years ago

That's the way has been designed, if you press AUTO is the logic that defines the state of the output, that will be off till an event will occur.

From Mobile.

ribico commented 7 years ago

Yes, I have no complaints about this. You can see the bug I mention if you enter the slot 1 in the demo board. Here, in OFF AUTO mode the lamp sometimes is shown correctly as OFF but sometime as ON. For example if you push the button AUTO the lamp goes always ON, even if it is OFF AUTO. Please note I am not complaining about the graphical interface, I am just complaining about the fact the SApp really consider this as ON even in OFF AUTO So if you set a notice if the slot is on for longer than.. it will always notify you.