search

soulsmods / DSMapStudio

A standalone map/level editor for Demon's Souls, Dark Souls 1/2/3, Bloodborne, Sekiro, and Elden Ring.
MIT License
495 stars 60 forks source link

Flexible BinaryReaderEx #856

Open vawser opened 7 months ago

vawser commented 7 months ago

Added a toggle to allow BinaryReaderEx to ignore Asserts. Added try catch to the Param Bank loads so they don't cause a DSMS crash if they fail.

Philiquaz commented 7 months ago

I'm happy for this to go in.

At some point I'd like to move the logic from dcx to binaryreader to handle other formats that may be fucked with, and from there figure out a way to handle the errors without having to add checks on every interaction with soulsformats. But for now this is an improvement.

vawser commented 7 months ago

Changed the bypass to BinaryReaderEx. Credit to ivi for this method.

Philiquaz commented 5 months ago

Per witchybnd updates, it seems "encryption technology" has gone futher than just abusing asserts or the dflt type. Is this PR still relevant to modding or is outdated without additional mitigations? How do we maintain a documentarian implementation that's also expected to read falsified files? This whole fight is a mess and I hate it here.