Ignore unsupported texture DDS type rather than crash

soulsmods / DSMapStudio

A standalone map/level editor for Demon's Souls, Dark Souls 1/2/3, Bloodborne, Sekiro, and Elden Ring.

MIT License

491 stars 60 forks source link

Ignore unsupported texture DDS type rather than crash #897

Closed Grimrukh closed 3 months ago

Grimrukh commented 4 months ago

Currently, DSMS crashes if it encounters a texture with a DDS type it can't read, like BC5U (even though the game may support these). It would be great if these textures could at least just be ignored. Screenshot below.

Thanks for all the hard work gang <3

Philiquaz commented 3 months ago

Will have to take a look. This looks like one of those places that was left as "bug to fix, we want to see these errors" rather than something we quietly ignore and never hear about.

Philiquaz commented 3 months ago

As of 1.11 should log texture errors instead of crashing. Feel free to reopen if something else goes wrong as a result.

RunDevelopment commented 3 months ago

@Philiquaz I believe this issue was fixed in #901.

Also, about the GetPixelFormatFromFourCC function: a few FourCC values are still missing (e.g. BC5S, which is used once in ER IIRC). I'm currently in the process of adding a new DDS decoder to a library, so feel free to copy what I do for converting FourCC to DXGI_FORMAT.

Edit: Damn, seconds too late :)