search

soulsmods / DSMapStudio

A standalone map/level editor for Demon's Souls, Dark Souls 1/2/3, Bloodborne, Sekiro, and Elden Ring.
MIT License
447 stars 58 forks source link

IconID for Elden Ring #926

Closed ReksRaven closed 1 month ago

ReksRaven commented 1 month ago

Currently the maximum amount of digits that can be placed into the IconID field is 4.

For example I changed the ID for Caestus which is 10800. Now I want to change it back but cant because the most I can type in is 1080. Even if I want to import the row directly through CSV it tells me that the number is to large. Kinda bad as even just clicking the Icon field will remove the 5th digit.

But maybe I am just doing smth wrong.

Philiquaz commented 1 month ago

Ah, looks like the same off-by-1 that chalice maps were suffering truncating the inputtext. As a note, you'll never get larger than 65535 as that's the maximum size of the data type (and what the format and game support). Since the csv part is working on my end I can only assume that's related. I've pushed a fix, now I have to decide on a 2nd hotfix or 1.11.2

Philiquaz commented 1 month ago

resolved in 1.11.1 hotfix 2

ReksRaven commented 4 weeks ago

Thank you for the quick fix o7