soulsmods / ModEngine2

Runtime injection library for modding Souls games. WIP
MIT License
850 stars 150 forks source link

Elden Ring Mod Engine 2 will open for a split second then close right away. #106

Open BobaFettTea009 opened 1 year ago

BobaFettTea009 commented 1 year ago

I also looked to see if i could change the location but in properties, it doesn't have the option to change location.

kami-sloth commented 1 year ago

Hey Boba, try editing the 'launchmod_eldenring.bat' with the "--game-path" and see if that works. Example: .\modengine2_launcher.exe -t er -c .\config_eldenring.toml --game-path "D:\SteamLibrary\steamapps\common\ELDEN RING\Game\eldenring.exe"

BobaFettTea009 commented 1 year ago

Thank you Kami. Unfortunately, I have no idea how to do this. is there any way to do a step-by-step or a video tutorial? I'm confused do I rename it or something?

kami-sloth commented 1 year ago

Ok, let me see if I can give you what you need. Soup-to-Nuts: Download DSL and ModEngine2: 1) Go here: https://www.nexusmods.com/eldenring/mods/2777?tab=description 2) Navigate a little down the page and you will see "Installation" this has a link to ModEngine2. 3) You can follow these instructions which will keep your normal elden ring directory untouched. 4) Once ModEngine2 is downloaded, you will need to 'right-click' and extract it to your desired location. -- I installed mine on my desktop for quick access. 5) Navigate into your ModEngine2 folder which if left default should be 'ModEngine-2.0.0-preview4-win64' -- In this folder you will see a 'mod' folder. 6) Download 'DSL' from the link in step 1 7) Extract the DSL mod into the mod directory. so the folder directory would look something like: This PC > Desktop > ModEngine-2.0.0-preview4-win64 > mod >DSL Beta 0.5 (Reupload)-2777-Beta05-1675030644 8) Navigate to This PC > Desktop > ModEngine-2.0.0-preview4-win64 > mod Optional (What I did): Right click the folder DSL Beta 0.5 (Reupload)-2777-Beta05-1675030644 and select Rename. Change this to just 'DSL-Beta' 9) You will see many files but the ones that we care about are: a) config_eldenring.toml b) launchmod_eldenring.bat 10) First Right-click the config_eldenring.toml then select Open with... A new window will open allowing you to select an app. We are looking for notepad. ---- Note, you might have to select 'more options' in the new window for the app to show up. ----- 11) you want to make sure you have the following line: mods = [ { enabled = true, name = "default", path = "mod\\DSL-Beta" } ] 12) Click on 'File' at the top of the notepad app and then click save 13) Once that line exists the assumption is your mod is installed at This PC > Desktop > ModEngine-2.0.0-preview4-win64 > mod > DSL-Beta 14) Now close the notepad window for the 'config_eldenring.toml' 15) Right-click the launchmod_eldenring.bat and select Edit1 which should opennotepad ----- This is different because the file extension is .bat which is a script that can be run ------- 16) Now with this open you will probably only see: .\modengine2_launcher.exe -t er -c .\config_eldenring.toml 17) add the following: .\modengine2_launcher.exe -t er -c .\config_eldenring.toml --game-path "D:\SteamLibrary\steamapps\common\ELDEN RING\Game\eldenring.exe 18) Finally clickFileat the top of thenotepadand clickSave 19)Double-clickthelaunchmod_eldenring.bat` and you should be off to the races.

-------------- Ensure that you change the path in between the " " to that of your path to your eldenring.exe --------------

Peppocoms commented 1 year ago

Hello, I've tried everything you said but the modengine still do not work. Have you any other idea?

File .bat edited and it is as this: _.\modengine2_launcher.exe -t er -c .\config_eldenring.toml --game-path "C:\Games\ELDEN_RING\eldenring.exe"_

In configeldenring.toml the line is like this: mods = [ { enabled = true, name = "default", path = "C:\Users\User\Downloads\ModEngine-2.0.0-preview3-win64\modengine\mod\DSL-Beta" } ]_

I added the underscore in "ELDEN RING" thinking it would solve the problem. No difference with or without.

ximbas2508 commented 1 year ago

hello i am having the same issue i made all the steps and still dont work tried everything and nothing works

kami-sloth commented 1 year ago

A couple of things to note for @Peppocoms and @ximbas2508 : 1: please ensure if you are using the full path that you use not 1 but 2 \ @peppocoms config_eldenring.toml for example would look like: mods = [ { enabled = true, name = "default", path = "C:\\Users\\User\\Downloads\\ModEngine-2.0.0-preview3-win64\\modengine\\mod\\DSL-Beta" } ]

Furthermore, ensure that in the .bat file you use the exact path, adding an _ to a path that is supposed to be a space will not work. The " " allow for the space key to be respected in the path.

Finally, if you set the debug = true in your config_eldenring.toml file, when you launch the game if it crashes it will create a new file in the same directory as the launch_eldenring.bat for the current date and you can view what the error is which can help with troubleshooting.

If it says something like no valid game found it means the path to your elden ring.exe is wrong. If you can post the error here it would help a lot.

Thanks,

ximbas2508 commented 1 year ago

done. but i still have the same issue it just split a empty CMD and close in a second and does nothing 😥

ximbas2508 commented 1 year ago

WhatsApp Image 2023-02-24 at 14 36 45 WhatsApp Image 2023-02-24 at 14 37 00 WhatsApp Image 2023-02-24 at 14 37 18 WhatsApp Image 2023-02-24 at 14 37 46 here are the photos of my code if you see anything wrong

kami-sloth commented 1 year ago

Thanks the screenshots are helpful. Can you navigate to the ModEngine-2.0.0-preview3-win64 folder and check for a file that ends in .log which should have todays date on it. If so, can you post a screenshot or attach?

In the launch_eldenring.bat you don't have to use the \\ instead you can just use \ for the path to your game only the 'config_eldrenring.tomlrequires the\`.

Finally, it looks like the mod code in your config_eldenring.toml has the name default for both, can you try making those unique? you can probably just call it default1 and default2

ximbas2508 commented 1 year ago

image this is what you need? image and i also changed to default 1 and default 2

ximbas2508 commented 1 year ago

sorry for answering it too late

kami-sloth commented 1 year ago

The log file from the 'debug' setting should be named: modengine_2023-02-24.log

Here is an example of my config_eldenring.toml image

Note: I didn't put my DSL into a sub directory because I only run that mod. You will see that my mod path is only set to 'mod' that is because I extracted my DSL specifically into there so the contents of the mod folder look like: image

Here is an example of my launchmod_eldenring.bat .\modengine2_launcher.exe -t er -c .\config_eldenring.toml --game-path "D:\SteamLibrary\steamapps\common\ELDEN RING\Game\eldenring.exe"

ximbas2508 commented 1 year ago

image this is the DSL mod, the same as yours image this is mine, config_eldenring.toml and i dont have the modengine_2023-02-24.log, neither the folder named debug

ximbas2508 commented 1 year ago

image this is the ME2

kami-sloth commented 1 year ago

Here is an example of the where we are working in.

image

kami-sloth commented 1 year ago

Sorry I misunderstood your screenshot. We don't use anything below my above screenshot so don't change or edit anything in there.

ximbas2508 commented 1 year ago

image here is mine less the part of darksouls

ximbas2508 commented 1 year ago

image here i downloaded again from the link you send me and made the changes, but still dont work

kami-sloth commented 1 year ago

Have you tried right-clicking the launch_eldenring.bat and doing Run as administrator? Normally I don't recommend this but certain windows OS's are locked down a bit more.

Also, if you haven't run with addons before, try running with only 1 addon at a time.

ximbas2508 commented 1 year ago

same problem even if i run it with administrator it dont work and also i changed it to just one mod at time but it didnt work

ximbas2508 commented 1 year ago

image

kami-sloth commented 1 year ago

Make sure that mods line has the full path defined by: "C:\\Users\\gabif\\OneDirve\\Area de Trabalho\\modengine\mod\ASCENDED" you need the double \

Silterv commented 1 year ago

Adding onto the same problem, when running launchmod_eldenring.bat in cmd with '--game-path [Elden Ring file path]' the cmd throws an unexpected argument error for the --game-path.

Moving the '--game-path' argument around, I replaced it with the 'er' argument .\modengine2_launcher.exe -t --game-path "[Elden Ring file path]" -c .\config_eldenring.toml which passes the argument but throws --launch-target: Check --game-path value in {ds3->1,er->2} OR {1,2} FAILED' instead.

ximbas2508 commented 1 year ago

@kami-sloth did it but still dont work i dont know what to do or were search for the answer

Peppocoms commented 1 year ago

@ximbas2508 Do you have a steam version or a downloaded version? I think the problme might be there... I have a downloaded version and nothing seems to work

ximbas2508 commented 1 year ago

i have a downloaded version i didnt buy it do you think this is the issue?

Peppocoms commented 1 year ago

@ximbas2508 I'm starting to think it is... In every guide on the internet they always talk about "steam" path etc... @kami-sloth Did you buy the game or just downloaded it?

ximbas2508 commented 1 year ago

but everygame i play i can download mods and play it without issue , everygame that i have i downloaded. only game that i cant is elden ring.

ximbas2508 commented 1 year ago

https://www.youtube.com/watch?v=kziBphPf034&t=396s i found this guy on youtube that says you can download mods without stean i am going to try it out and say if works

ximbas2508 commented 1 year ago

For me it didnt work

ximbas2508 commented 1 year ago

FINALY MY GAME OPENED https://www.youtube.com/watch?v=C6fc_2WoP04&t=8s found this another video and my game opened but didnt load the mods

ximbas2508 commented 1 year ago

@kami-sloth my game now created a.log file down here it is [2023-02-25 17:13:50.768] [modengine] [info] ModEngine version 2.0.0-preview3-d673e6000e50d5c559364b6276057f6bde09accb initializing for Elden Ring [2023-02-25 17:13:50.768] [modengine] [info] Local settings loaded: false, Global settings loaded: true [2023-02-25 17:13:50.768] [modengine] [info] Main thread ID: 4660 [2023-02-25 17:13:50.773] [modengine] [info] Enabling extension base [2023-02-25 17:13:50.773] [modengine] [info] Enabled extension base [2023-02-25 17:13:50.774] [modengine] [info] Applied 1 hooks [2023-02-25 17:13:50.782] [modengine] [info] Starting worker thread [2023-02-25 17:17:30.528] [modengine] [info] ModEngine version 2.0.0-preview3-d673e6000e50d5c559364b6276057f6bde09accb initializing for Elden Ring [2023-02-25 17:17:30.528] [modengine] [info] Local settings loaded: false, Global settings loaded: true [2023-02-25 17:17:30.528] [modengine] [info] Main thread ID: 14624 [2023-02-25 17:17:30.534] [modengine] [info] Enabling extension base [2023-02-25 17:17:30.535] [modengine] [info] Enabled extension base [2023-02-25 17:17:30.535] [modengine] [info] Applied 1 hooks [2023-02-25 17:17:30.544] [modengine] [info] Starting worker thread [2023-02-25 17:17:31.152] [modengine] [info] Destroying [2023-02-25 17:17:31.152] [modengine] [info] Destroying [2023-02-25 17:17:31.152] [modengine] [info] Destroying [2023-02-25 17:17:31.152] [modengine] [info] Destroying [2023-02-25 17:17:31.152] [modengine] [info] Destroying [2023-02-25 17:17:31.152] [modengine] [info] Destroying [2023-02-25 17:17:31.152] [modengine] [info] Destroying [2023-02-25 17:17:31.152] [modengine] [info] Destroying [2023-02-25 17:17:31.152] [modengine] [info] Destroying [2023-02-25 17:17:31.154] [modengine] [info] Destroying [2023-02-25 17:18:58.029] [modengine] [info] ModEngine version 2.0.0-preview3-d673e6000e50d5c559364b6276057f6bde09accb initializing for Elden Ring [2023-02-25 17:18:58.029] [modengine] [info] Local settings loaded: false, Global settings loaded: true [2023-02-25 17:18:58.029] [modengine] [info] Main thread ID: 14200 [2023-02-25 17:18:58.034] [modengine] [info] Enabling extension base [2023-02-25 17:18:58.034] [modengine] [info] Enabled extension base [2023-02-25 17:18:58.034] [modengine] [info] Applied 1 hooks [2023-02-25 17:18:58.038] [modengine] [info] Starting worker thread [2023-02-25 17:18:58.622] [modengine] [info] Destroying [2023-02-25 17:18:58.622] [modengine] [info] Destroying [2023-02-25 17:18:58.622] [modengine] [info] Destroying [2023-02-25 17:18:58.622] [modengine] [info] Destroying [2023-02-25 17:18:58.622] [modengine] [info] Destroying [2023-02-25 17:18:58.622] [modengine] [info] Destroying [2023-02-25 17:18:58.622] [modengine] [info] Destroying [2023-02-25 17:18:58.622] [modengine] [info] Destroying [2023-02-25 17:18:58.622] [modengine] [info] Destroying [2023-02-25 17:18:58.622] [modengine] [info] Destroying

ximbas2508 commented 1 year ago

guys i finally made it solved the issue let me show you guys my mod loaded

ximbas2508 commented 1 year ago

first you go to yours mod engine folder image and wwrite there cmd press tab and find the launch mod eldenring, and press enter and follow the steps of the last link and video i sent to put the game on the right folder if theren stil any issue sent me a message thanks @kami-sloth for the help and everithing realy apreciate it 😁😁😁😁

Peppocoms commented 1 year ago

I have tried running through cmd but i get the error: _C:\Users\User\Downloads\ModEngine-2.0.0-preview3-win64\modengine>.\modengine2_launcher.exe -t er -c .\config_eldenring.toml --game-path "C:\Games\ELDEN_RING\eldenring.exe" The following arguments were not expected: C:\Games\ELDEN_RING\eldenring.exe --game-path Run with --help for more information._

If I try without "path" i get: _C:\Users\User\Downloads\ModEngine-2.0.0-preview3-win64\modengine>.\modengine2_launcher.exe -t er -c .\configeldenring.toml [2023-02-27 08:33:05.099] [stderr] [error] Couldn't find path to game

Any idea why is not working for me? Do I have to create the "steam" path on my own to make it work?

Peppocoms commented 1 year ago

I tried moving the game to Steam folder and adding the .acf... Still not working. I think I'm missing something Path of the game Right now: C:\Steam\steamapps\common\ELDEN RING launchmod: _.\modengine2_launcher.exe -t er -c .\configeldenring.toml config_eldenring.toml: mods = [ { enabled = true, name = "default1", path = "mod" } ]

immagine

Peppocoms commented 1 year ago

@ximbas2508 have you any other idea? ELDEN RING is in this path right now: C:\Steam\steamapps\common\ELDEN RING Got appmanifest with rifght ID: immagine When I open the steam app i can't see ELDEN RING (maybe normal, i don't know anymore at this point...)

Got any idea?

Peppocoms commented 1 year ago

@ximbas2508 got a new error after adding it to steam:

**_C:\Users\User\Downloads\ModEngine-2.0.0-preview3-win64\modengine>launchmod_eldenring.bat

C:\Users\User\Downloads\ModEngine-2.0.0-preview3-win64\modengine>.\modengine2_launcher.exe -t er -c .\config_eldenring.toml [2023-02-27 17:27:36.043] [stderr] [error] Couldn't create process: 10b

C:\Users\User\Downloads\ModEngine-2.0.0-preview3-win64\modengine>_**

Peppocoms commented 1 year ago

Solved my proplem... Added it to Steam library thanks to your video @ximbas2508 and had to put the whole game into C:\Steam\steamapps\common\ELDEN RING\game(real game files) After that, without modifying the modengine files everything worked

hosbdu commented 1 year ago

Solved my proplem... Added it to Steam library thanks to your video @ximbas2508 and had to put the whole game into C:\Steam\steamapps\common\ELDEN RING\game(real game files) After that, without modifying the modengine files everything worked

i have all my files in there and it still crashes, do we know what is going on with it.

ximbas2508 commented 1 year ago

Solved my proplem... Added it to Steam library thanks to your video @ximbas2508 and had to put the whole game into C:\Steam\steamapps\common\ELDEN RING\game(real game files) After that, without modifying the modengine files everything worked

did you solved the problem? can you play it now? sorry for beeing too late for helping you if there anymore issue i can help with that

ximbas2508 commented 1 year ago

Solved my proplem... Added it to Steam library thanks to your video @ximbas2508 and had to put the whole game into C:\Steam\steamapps\common\ELDEN RING\game(real game files) After that, without modifying the modengine files everything worked

i have all my files in there and it still crashes, do we know what is going on with it.

did you got a picture of the error?

DennasTrue commented 1 year ago

Solved my proplem... Added it to Steam library thanks to your video @ximbas2508 and had to put the whole game into C:\Steam\steamapps\common\ELDEN RING\game(real game files) After that, without modifying the modengine files everything worked

i have all my files in there and it still crashes, do we know what is going on with it.

did you got a picture of the error?

I have do everything above ,and the steam already recognized elden ring in the library, but I still got this
image I didn't know why game keep refusing to recognize directory,and I already tried to adding game path as well. ,also for reference my elden ring is 1.081 if its a problem

ximbas2508 commented 1 year ago

you got to specify where your mod is installed

Peppocoms commented 1 year ago

@DennasTrue You have to follow the spanish guide to add the application "pointer" in Steam. Then you must have all folders in another folder, so like this .../ELDEN RING/game/all-files immagine

immagine

Let me know if it's more clear this way.

DennasTrue commented 1 year ago

@DennasTrue You have to follow the spanish guide to add the application "pointer" in Steam. Then you must have all folders in another folder, so like this .../ELDEN RING/game/all-files immagine

immagine

Let me know if it's more clear this way.

I already do that image

image

image

But it still give me this no matter what I do

Peppocoms commented 1 year ago

After everything you have done, you can launch the batfile without changes, no need to change anything on mod engine. If you want i can share my email with you and send a meet :D

DennasTrue commented 1 year ago

After everything you have done, you can launch the batfile without changes, no need to change anything on mod engine. If you want i can share my email with you and send a meet :D

I don't know why but I still can't launch the batfile even without changing anything on batfile

DennasTrue commented 1 year ago

never mind I found the fix,the way to fix is method above but it must Game/game not Games. the extra s made mod launcher unable to found the game

5ilvar commented 1 year ago

Ive been able to play with the Mod Engine 2 until now, but one day, the launcher would not open the game and it shows me this (I play a pirated version btw) mod brrr