soulsmods / ModEngine2

Runtime injection library for modding Souls games. WIP
MIT License
885 stars 160 forks source link

Provide better diagnostics for failed hooks #156

Open nex3 opened 11 months ago

nex3 commented 11 months ago

As part of porting the Archipelago mod to ModEngine2, I made an attempt to move its hook detection to the ME2 extension API's register_hook function. However, the first AOB I ported over failed, and the failure crashed the entire DS3 process without any diagnostics or even any logs being written. This makes it very hard to even begin to figure out why it's not working and how to fix it. Since AOBs are likely to be somewhat fragile, especially as new patch versions get released, it would be very useful to have better diagnostic tooling for why they fail when they fail. Some things that would be helpful: