search

soulwing / cas-extension

CAS Extension for Wildfly
Other
5 stars 5 forks source link

Wildfly 14 support #14

Closed sutrap closed 5 years ago

sutrap commented 6 years ago

Is it possible to adapt the module for wildfly up to 14?

ceharris commented 6 years ago

Yes. I've actually got a work project that uses this extension that needs to get updated from Wildfly 10 to Wildfly 12-14. We're scheduled do to that work between mid-November and mid-December, which means we'll be updating this extension during that same timeframe.

sutrap commented 6 years ago

Maybe you can check my patch. It compiles now with wildfly14 profile... I will make more checks on weekend. wildfly14.zip

ceharris commented 5 years ago

Have you been successfully running the extension with this patch applied?

sutrap commented 5 years ago

Yes. my config works so far. Do you have problems?

I didn't check any side effects and tried just to get it working, what it did :D

Am Di., 11. Dez. 2018 um 19:19 Uhr schrieb Carl Harris < notifications@github.com>:

Have you been successfully running the extension with this patch applied?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/soulwing/cas-extension/issues/14#issuecomment-446306069, or mute the thread https://github.com/notifications/unsubscribe-auth/ADzvAkATdVlvT9AV0iWrsrbMrLnHINPqks5u3_cagaJpZM4YUuk5 .

ceharris commented 5 years ago

No problems, just wanted to confirm that someone else was testing it before I merged the patch into the code base.

ceharris commented 5 years ago

I created PR #15 from your patch and merged it. I need to do some more testing myself before I create a new versioned release.

sutrap commented 5 years ago

You might consider that it breaks other versions!

As the API changed I dont think it is possible to have a common codebase for wildfly 10 and wildfly 14...

Am Di., 11. Dez. 2018 um 19:55 Uhr schrieb Carl Harris < notifications@github.com>:

I created PR #15 https://github.com/soulwing/cas-extension/pull/15 from your patch and merged it. I need to do some more testing myself before I create a new versioned release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/soulwing/cas-extension/issues/14#issuecomment-446318713, or mute the thread https://github.com/notifications/unsubscribe-auth/ADzvAgbApaKNvQxOUNv9IGJ3O1N-epfZks5u3_-7gaJpZM4YUuk5 .

ceharris commented 5 years ago

Understood.

singhindresh commented 5 years ago

Hi Carl, Can you please provide build instruction for wildfly 14. I'm trying to build the master with "mvn clean install" but I'm getting error. Thanks for your help.

Regards, Indresh

ceharris commented 5 years ago

It is necessary to enable two maven build profiles, similar to what was needed for Wildfly 10. I've updated the README, accordingly

singhindresh commented 5 years ago

Thanks Carl! Web authentication is working but EJB authentication is failing. I assume setup should work as in legacy security subsystem (PicketBox).

Exception stack trace: org.jboss.as.ejb3.security.AuthorizationInterceptor.processInvocation(AuthorizationInterceptor.java:134) org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:422) org.jboss.as.ejb3.security.SecurityContextInterceptor.processInvocation(SecurityContextInterceptor.java:100) org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:422)

singhindresh commented 5 years ago

Carl, I was able to resolve the issue. My EJB authentication error was due to default-missing-method-permissions-deny-access.

ceharris commented 5 years ago

Awesome. Glad to know that still works!