search

soumak77 / firebase-mock

Firebase mock library for writing unit tests
https://soumak77.github.io/firebase-mock
350 stars 96 forks source link

Fix Order by (and Issue 81 onsnapshot implementation) #145

Open BrianChapman opened 5 years ago

BrianChapman commented 5 years ago

Fixing the Orderby conflicted with changes in PR #130 (the onsnapshot implementation) so this is a merge of both changes. Probably can close pull #130 if this gets merged in.

Venryx commented 4 years ago

Oops. It looks like I based my fixed pull-request (#158) on your old onSnapshot pull-request (#130), not this newer one.

I'd rebase my changes on this pull-request, except it looks like @soumak77 is not currently active on evaluating/merging pull-requests.

Anyway, this pull-request adds basic onSnapshot support + orderBy for it, whereas mine (#158) adds basic onSnapshot support + fixes for two broken cases.

I don't need orderBy currently so am too lazy to update my branch, but if @soumak77 returns to take a look at the pull-requests, I can do the rebasing procedure mentioned.