Open jrmd opened 5 years ago
Thanks for the contribution! This repo is no longer usable. Can you re-open here?
Also, can you fix the broken unit test and add coverage for the new operators? We're shooting for a release soon after December 1 so if you have time to submit a PR before next Thursday that will give us the best chance of including this change.
@dmurvihill I will certainly try find the time! currently i have my own forked version published but it would be good to get a common fork
Cheers. We're also looking for co-maintainers.
@dmurvihill was this PR opened on https://github.com/dmurvihill/firebase-mock ? I can't see that it was?
Hi @alexpchin, thanks for asking! This pull request lacks test coverage and as a result it incorrectly handles comparisons between types (see How query data is ordered). I've added a branch dmurvihill:feature/add-all-where-operators that merges with master and adds stub unit tests; if you can carry it the rest of the way and open a PR to my fork I would be grateful.
Try the priorityComparator
function in utils.js
; I think it's close to correct.
This is very similar to #116 however this doesn't make use of
eval
which is a security issue.