search

soumak77 / firebase-mock

Firebase mock library for writing unit tests
https://soumak77.github.io/firebase-mock
349 stars 97 forks source link

Incorrect Bucket File download Api #163

Open hadson19 opened 4 years ago

hadson19 commented 4 years ago

I've looked into the code Firebase Bucket Storage File (firebase-admin: "8.3.0") and found that when we call download - the content should be returned in any case..

  export declare type DownloadResponse = [Buffer];
  export declare type DownloadCallback = (err: RequestError | null, contents: Buffer) => void;

What do you think about this? Thanks.

hadson19 commented 4 years ago

Should be fixed bu pull request https://github.com/soumak77/firebase-mock/pull/128/files