search

soumik12345 / wandb-addons

Weights & Biases Addons is a repository consisting of additional unitilities and community contributions for supercharging your Weights & Biases workflows.
https://geekyrakshit.dev/wandb-addons/
23 stars 7 forks source link

max_visualizations_per_split: Optional[int] = None should be 0 #23

Closed ayulockin closed 1 year ago

ayulockin commented 1 year ago

We get this error when we pass create_visualizations=True.

image

This is because if max_visualizations_per_split is not defined, None is compared with the cardinality of the dataset (https://github.com/soumik12345/wandb-addons/blob/6965a416ad5aaa6f8c7422fae1c4ebc6a2e0fc37/wandb_addons/dataset/table_creation.py#LL55C13-L55C13).

Easy fix, make the default value of max_visualizations_per_split = 0.

cc: @soumik12345