soumik12345 / wandb-addons

Weights & Biases Addons is a repository consisting of additional unitilities and community contributions for supercharging your Weights & Biases workflows.
https://geekyrakshit.dev/wandb-addons/
23 stars 7 forks source link

Fix Keras3 imports #59

Open shivance opened 1 year ago

shivance commented 1 year ago

How I found this issue?

Screenshot 2023-10-22 at 4 54 00 PM

What's going on?

The reason we are facing this issue is #51 . It depends on keras now, however there might have been a small confusion.

image

Keras3 release has not updated keras on pypi however it is still being continued as Keras Core (apparently they are waiting for a stable release to update Keras package on pypi)

image

cc: @soumik12345 @suvadityamuk

soumik12345 commented 1 year ago

@shivance Thanks for reporting the issue. Would you be willing to submit a PR to fix it?

shivance commented 1 year ago

@soumik12345 we could just revert the commit, can't we?

soumik12345 commented 1 year ago

@shivance I'm not a huge fan of reverting commits, its always better to patch.