SWHC001-05 submission1

[simularis]

We are sharing our work on SWHC001-05 transition to EnergyPlus.

This branch of changes includes a few changes beyond the measure definition. Here is an outline:

• Normalizing units: we wanted to extract heating capacity from models. For that we created a second query file. However, the rakefile seems to trigger simulation runs after we change the query file. So we also included a script to extract that data outside of the rakefile.
• To insert normalizing units into sim_annual style tables prior to further calculations, we also included a script to insert the units into sim_annual. Note that the script includes the residential adjustment steps (number of dwelling) units to match the expectation in post-processing script.
• In residential data transformation scripts, we made adjustment that corrects an issue where more than one "Common_PreTechID" in the batch of measures causes the renaming step to fail silently and generate duplicate rows with mismatched data.

Behzad was the main contributor to this work. @behzadsalimian

[simularis]

If it helps, I can split this into multiple requests and include the pull request template ...

[amine-lazrak]

@simularis Sure, please do. I think that would make the review easier. Thank you for the suggestion.

[simularis]

To demonstrate the results.py and insert_normunits.py scripts, attached are the results for the DMo building type.

I would like to code the steps to generate these into the rakefile or other supplemental script. In the meanwhile, here is what I entered on command line, including the revised results.py script in new location.

cd C:\DEER-Prototypes-EnergyPlus
cd "residential measures/SWHC001-05 Wall Furnace/SWHC001-05 Wall Furnace_DMo"
modelkit rake
python "../../../scripts/data transformation/DMo.py"
cp "../../../scripts/data transformation/sim_annual.csv" .

At this point, I have sim_annual.csv.

python "../../../scripts/result.py" . --queryfile "query_Wall Furnace.txt"
python "../../../scripts/data transformation/insert_normunits.py" results-sizing-agg.csv sim_annual.csv results-per-dwelling.csv sim_annual_withunits.csv "Coil:Heating:Fuel Design Size Nominal Capacity (W)" "CapOut-kBtuh" 0.2930710701832112 "Wall Furnace"

At this point, I have sim_annual_withunits.csv.

SWHC001-05 Wall Furnace_DMo results.zip

[simularis]

Just checking in. I believe we have addressed the review comments aside from the one about error handling messages in the result scraping script.

[lyt5410]

To demonstrate the results.py and insert_normunits.py scripts, attached are the results for the DMo building type.

I would like to code the steps to generate these into the rakefile or other supplemental script. In the meanwhile, here is what I entered on command line, including the revised results.py script in new location.

cd C:\DEER-Prototypes-EnergyPlus
cd "residential measures/SWHC001-05 Wall Furnace/SWHC001-05 Wall Furnace_DMo"
modelkit rake
python "../../../scripts/data transformation/DMo.py"
cp "../../../scripts/data transformation/sim_annual.csv" .

At this point, I have sim_annual.csv.

python "../../../scripts/result.py" . --queryfile "query_Wall Furnace.txt"
python "../../../scripts/data transformation/insert_normunits.py" results-sizing-agg.csv sim_annual.csv results-per-dwelling.csv sim_annual_withunits.csv "Coil:Heating:Fuel Design Size Nominal Capacity (W)" "CapOut-kBtuh" 0.2930710701832112 "Wall Furnace"

At this point, I have sim_annual_withunits.csv.

SWHC001-05 Wall Furnace_DMo results.zip

Thanks for showing this. I did some test runs on my end. The scripts ran fine without error. However, my numunits field is blank. So dues the "myunits_weighted.csv" and "results-per-dwelling.csv" tables generated. Does this have to do with modelkit output settings (certain output fields not displayed in the output csvs from the idfs?)

Please advise @simularis.

See screenshot. I attached my output files as a zip here.

test_run_YL.zip also current_msr_mat.csv didn't get updated with the correct norm unit (may cause some conflicts later?)

[simularis]

@lyt5410 , thank you for testing and thorough debugging.

I think the issue is that the script was looking for the measure to be entered in the default Measure List file location, but I did not give instructions to take that step. I have updated the readme and script to try to make this more explicit.

[lyt5410]

@simularis, I reran results.py and insert_normunits.py for testing, script runs no problem now with correct outputs, after I added the records from "SWHC001-Wall-Furnace_Measure_list.xlsx" to the main measure list "DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx" under data transformations folder. (the one with the suffix "_working" is the most up-to-date one. We will archive/remove the older one in a separate commit to avoid confusion, sorry about having 2 measure list files.)

@amine-lazrak This can be merged now. I tested the normunit extraction scripts and they are good.