Add four performance curves for DX Cooling Coil taken from Carrier document to update unitary.pxt

[wsjsxn]

Energy Solutions collected the catalog data from various HP manufacturers and add four performance curves for DX Cooling Coil taken from Carrier document https://www.shareddocs.com/hvac/docs/1009/Public/06/25VNA4-02PD.pdf model 25VNA436. The goal is to include these performance curves in the DEER prototype library and let the users to choose them for their modeling purpose.

[amine-lazrak]

Thank you for your efforts on the new feature. Before merging it into the main branch, we have a few requests for changes:

Pull Request (PR) Template: Please ensure you follow the PR template directions that appear when creating a new PR. We ask contributors to go through and select each required step in the template and confirm its completion.

Completeness of Performance Curves: The performance curves submitted are for a variable speed system, and there are two modeling options to consider. Option 1 involves using a multi-speed EnergyPlus object, requiring curves for each speed level. Currently, it seems only one set of curves for one speed is provided. Option 2 involves using the variable speed object, necessitating multiple curves for different speeds. The variable speed model is not implemented in the unitary.pxt template. If you choose to add it, we recommend exploring this package for performance tables generation. If you're not following these two options, we would appreciate more context and justification for the chosen approach in modeling a variable speed HP with a single set of curves.

Lack of Parameterization: The curves were added without parameterization, making it challenging for users to select between curves using a parameter. We expect any new addition to seamlessly integrate into the modeling framework, requiring minimal adjustments on our end. Please review how existing curves are parameterized (e.g., see the parameter dx_type).

Missing Simulation Results Examples: The pull request lacks simulation result examples (of your choice), as specified in the pull request template. Your inclusion of these examples will greatly assist in the review process.

[wsjsxn]

I used COIL:COOLING:DX:MULTISPEED with 4 speeds to simulate the variable speed heat pump. For variable speed heat pump, none of the manufacture's catalogs provide the performance data of the DX coil at different speeds. Therefore, I have to use the same set of the performance curves for each speed level.

[amine-lazrak]

That's one approach if you find it reasonable. Does the manufacturer provide minimum and maximum values at specific rating conditions? If you can identify the system you want to model among those listed here, then I recommend using this tool to build the curves at different speeds.

Example:

For instance, if you want to model this system, you would need to extract the data from the table on that page and input it into the Python tool. You can find an example here. After running the package, a new folder named output will be created, containing the IDF of the system you want to model with all performance data in tables that can be directly referenced in the variable-speed EnergyPlus object.

[wsjsxn]

Thanks for your info on resdx github repo for curve generation and I will take a look at it. Best,

Shaojie Wang

Ph.D., PE, LEED AP

On Mon, Feb 26, 2024 at 12:33 PM Amine Lazrak @.***> wrote:

That's one approach if you find it reasonable. Does the manufacturer provide minimum and maximum values at specific rating conditions? If you can identify the system you want to model among those listed here https://ashp.neep.org/#!/product_list/, then I recommend using this tool https://github.com/bigladder/resdx/tree/mainto build the curves at different speeds. Example:

For instance, if you want to model this system https://ashp.neep.org/#!/product/95190/7/25000/95/7500/0///0, you would need to extract the data from the table on that page and input it into the Python tool. You can find an example here https://github.com/bigladder/resdx/blob/13f14b1daf633accb7c1945f6469d6cd57854290/examples/neep-examples.py#L57. After running the package, a new folder named output will be created, containing the IDF of the system you want to model with all performance data in tables that can be directly referenced in the variable-speed EnergyPlus object.

— Reply to this email directly, view it on GitHub https://github.com/sound-data/DEER-Prototypes-EnergyPlus/pull/21#issuecomment-1964862846, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANFQPGIZ356Y7MLOP4KN7VLYVTIQLAVCNFSM6AAAAABCXDCWWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUHA3DEOBUGY . You are receiving this because you authored the thread.Message ID: @.***>

[amine-lazrak]

@wsjsxn Are you planning to make more changes to this pull request? Let us know when this is ready to be reviewed.

[wsjsxn]

@amine-lazrak I have completed all the changes for this pull request. You can start to review this pull request. Thanks,

[amine-lazrak]

@wsjsxn This PR branch is 83 commits behind the main branch. Could you please update your branch so that it's up to date with main? I'll review it right after.

[wsjsxn]

I have updated my branch with all the changes from the main branch. Thanks

[amine-lazrak]

@wsjsxn The newly added curves are identical to the existing ones when dx_type equals SPLIT. Was this intentional? If so, are you suggesting changing the name of the system curves? In that case, I wonder if we should add an if statement that defaults to SPLIT when users choose Carrier25VNA436 instead of adding the entire curves again.

[wsjsxn]

I revised the coefficients for newly added cooling/heating capacity and EIR performance curves

[amine-lazrak]

Closed for now; may revisit if relevant in the future.