sound-data / DEER-Prototypes-EnergyPlus

13 stars 4 forks source link

Fix bug where rNCGF was converted to blank in sim_hourly_wb #3

Closed simularis closed 1 year ago

simularis commented 1 year ago

We tried to run gas furnace measures including cases where BldgHVAC=rNCGF. We were finding that in sim_hourly_wb.csv, the rows for rNCGF instead had BldgHVAC=null. However, sim_annual.csv was not having this problem. The difference appears to be due to hvac_str().

The proposed patch adapts parse_measure_name() for use with pandas.Series input in bulk. This is more similar to parse step used for sim_annual. It works with just the cohort name or the full path (with forward slashes) to instance-var.csv.

Also, parse_measure_name2() provides more descriptive error messages in case of malformed cohort name, e.g.: