sound-data / DEER-Prototypes-EnergyPlus

11 stars 4 forks source link

SWHC004 Space Heating Boiler (residential subset) #31

Closed simularis closed 2 months ago

simularis commented 3 months ago

Pull Request (PR) Description

This pull request is to include a measure setup for SWHC004. For this measure, we have made the following setup:

PR Author

amine-lazrak commented 2 months ago

@simularis Could you please update your pull request branch to incorporate the latest changes from the main branch? This will help ensure that any conflicts are resolved before we proceed with the review.

simularis commented 2 months ago

Updated to incorporate the latest changes from the main branch.

amine-lazrak commented 2 months ago

@simularis Can you please create a new folder to store the new root files for consistency with others. I would recommend to use MFm-1985-boiler and MFm-New-boiler.

I was wondering if you've come across the error ** Fatal ** The SQLite database failed to open in some cases (e.g. CZ01\MFm&0&rNCHW&Ex&SpaceHtg_eq__HotWaterBoiler)? When I run the cases independently outside of Modelkit, it works fine without any issues. This problem appears to be sporadic and isn't related to your PR. However, if more users experience the same issue, we may need to open a GitHub issue to investigate further at a later stage.

lyt5410 commented 2 months ago

I did test run after Amine's request. I have the same SQLite fatal error (only for some runs). I tested CZ01, 02 and 03. The fatal error happened for 2 of the baseline (AFUE83, AFUE84) and the AFUE85.3 Msr case. Other cases (AFUE85, 93, 94) ran without error. @amine-lazrak @simularis

simularis commented 2 months ago

Renamed the boiler prototypes per Amine's comment.

simularis commented 2 months ago

Regarding the error message mentioned above, we had not encountered that. Thank you for testing. I am assuming that message is coming from Modelkit, rather than from EnergyPlus or the Python data transformation script? I wonder if it may be related to path length, e.g. if the file name is too long.

amine-lazrak commented 2 months ago

Regarding the error message mentioned above, we had not encountered that. Thank you for testing. I am assuming that message is coming from Modelkit, rather than from EnergyPlus or the Python data transformation script? I wonder if it may be related to path length, e.g. if the file name is too long.

I'm not completely certain, but we'll look into it to confirm. We've encountered issues with Windows file names length before, but the error message was different then. This current error seems unrelated to Modelkit because others (1,2) using different tools have reported the same problem. Thank you for the update.

simularis commented 2 months ago

Thanks for sharing info about that error. There is also an issue on EnergyPlus github, #7512. It would be helpful to collect the folder from a simulation instance that failed, so we could examine the sqlite error log and sql file.

Come to think of it, I have had some problems getting BEopt to run with a high number of threads. I wonder if that is related.