sound-data / DEER-Prototypes-EnergyPlus

11 stars 4 forks source link

Disable EMS to fix linked sizing #60

Open simularis opened 2 months ago

simularis commented 2 months ago

Pull Request (PR) Description

29 seems to break the linked sizing feature of modelkit in commercial prototypes. This pull request is meant to restore the ability to do linked-sizing.

The problem

To reproduce the error when utilizing linked-sizing:

Proposed solution

The proposed solution is to disable the block of EMS logic in unitary.pxt added recently, by creating a parameter to guard that block of code. The logic will be enabled by default (disable_ems = false), but users can include disable_ems = true as an input parameter to turn it off.

PR Author