29 seems to break the linked sizing feature of modelkit in commercial prototypes. This pull request is meant to restore the ability to do linked-sizing.
Creates a new parameter disable_ems
Also addresses #59
The problem
To reproduce the error when utilizing linked-sizing:
User has a cases CSV file with the column sizing_case and at least one row refers to another.
User composes linked-size models with command line modelkit rake hardsize or goes straight ahead to simulation with modelkit rake. The resulting models look like instance-hardsize.idf.
After running the models, the user may see an error message in instance-hardsize-out.err that there is no System:Sizing object, although there are Autosize input fields present.
Proposed solution
The proposed solution is to disable the block of EMS logic in unitary.pxt added recently, by creating a parameter to guard that block of code. The logic will be enabled by default (disable_ems = false), but users can include disable_ems = true as an input parameter to turn it off.
PR Author
[X] Make sure the PR branch is up to date with main branch at the time of the PR submission
[X] Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
[ ] Label the PR with at least one of the following: New Measure, Bug, or Feature.
[X] Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
[ ] For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
[x] Add comments in the code when necessary to facilitate the review process.
[x] Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
[ ] For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
[ ] For a new measure, add a summary table showing total energy consumption per simulated case.
PR Reviewer
[ ] Conduct a thorough code review.
[ ] If the branch is behind the main, merge the branch locally to check for potential conflicts.
[ ] If a bug, locally reproduce it and compare energy consumptions before and after.
[ ] Explore creative ways to stress-test the code.
[ ] Locally check the error file and other outputs.
Pull Request (PR) Description
29 seems to break the linked sizing feature of modelkit in commercial prototypes. This pull request is meant to restore the ability to do linked-sizing.
disable_ems
The problem
To reproduce the error when utilizing linked-sizing:
sizing_case
and at least one row refers to another.modelkit rake hardsize
or goes straight ahead to simulation withmodelkit rake
. The resulting models look likeinstance-hardsize.idf
.instance-hardsize-out.err
that there is no System:Sizing object, although there are Autosize input fields present.Proposed solution
The proposed solution is to disable the block of EMS logic in
unitary.pxt
added recently, by creating a parameter to guard that block of code. The logic will be enabled by default (disable_ems
= false), but users can includedisable_ems
= true as an input parameter to turn it off.PR Author
PR Reviewer