search

soundar24 / vue-round-slider

A round slider component for Vue JS, with range slider support. Also it can be any kind of arc slider such as pie shape, half / semi-circle, quarter circle shape sliders.
https://vue.roundsliderui.com/
MIT License
69 stars 14 forks source link

v-on:change event not firing. #2

Closed TAUFEEQ1 closed 4 years ago

TAUFEEQ1 commented 4 years ago

Hello Thank you for this tool. change event is not firing.

soundar24 commented 4 years ago

Hi @TAUFEEQ1, since this acts like a wrapper for roundSlider the events will be treated as props. So the events should be passed like v-bind:change="handler" or :change="handler" instead of v-on. I have updated the same info in the readme also.

Check the below demo and let me know your comments.

https://codesandbox.io/s/vue-round-slider-event-binding-x2emq?file=/src/components/SliderDemo.vue

Thanks..

TAUFEEQ1 commented 4 years ago

Hello, @soundar24 , The change handler is still not firing.

https://codesandbox.io/s/vue-round-slider-event-binding-o0e7j?file=/src/components/SliderDemo.vue

soundar24 commented 4 years ago

@TAUFEEQ1 yes I can find this issue. While click on the slider range, at that time change event was triggered. But when drag the handle and release, at that time change doesn't triggered (seems broken in the recent release).

I will fix this and release in.a couple of days. Good finding, thanks..

soundar24 commented 4 years ago

@TAUFEEQ1 The change event related issue was resolved, and updated in the below release [v1.0.1]

https://github.com/soundar24/vue-round-slider/releases/tag/v1.0.1

You can simply update to this version and confirm. I have updated in the same demo where change event is working fine.

https://codesandbox.io/s/vue-round-slider-event-binding-x2emq

Please check and let me know if you have any other concerns.. thanks...

TAUFEEQ1 commented 4 years ago

Yes its working, Thank you.