Closed phpfui closed 1 year ago
@phpfui Thank you! This looks great. I'll get this merged in and get a release out over the holiday break.
Ed,
Hope you had a good XMas weekend. Any chance you could merge and publish a release? I have three PR's for 8.2 compatibility. One merged, two to go, and you can make it one to go!
This is a well thought out package and would love to see it continue.
Thanks.
@edgrosvenor any chance we can get this merged and a new release published? The PR looks like a lot of changes, but most are just housekeeping / cleanup. Let me know if you have any questions / issues.
@phpfui All set. Thank you!
PHP 8.2 depreciated
mb_convert_encoding($html, "HTML-ENTITIES", "UTF-8");
The solution was to correctly specify the character set when loading the DOM. Unfortunately, that only works on PHP 8.1 and higher, probably due to some bug that was fixed. So I detect PHP 8.0 and lower and use the previous logic. Not pretty, but it works.I also modernized the package with the following improvements:
char_set
to allow people to use a specific character set if knownchar_set
option defaults to auto detectchar_set
optionToDo: