checking in `jquery.dropdown.css`

[thasner]

since the repository is often used as a distribution package, in addition to development environments. This allows better flexibility for consuming the library.

Note that future changes to jquery.dropdown.less will require contributors to also re-compile jquery.dropdown.css, but this shouldn't be a problem since they're already required to re-compile jquery.dropdown.min.css

[adidahiya]

:+1:

[ashwinr]

ping. sorry, can we please get this merged in? It's blocking our use of this library.

[claviska]

Why the need for this? Development isn't a good reason because you should be using the Less version. I've never required raw, unminified CSS for a project that uses Less/Sass. If you really need it, you can compile it yourself or run it through DirtyMarkup.

So, genuinely curious as to why one would want this. Aside from that, I'm also reluctant because the current "build process" is via CodeKit and would have to be moved to Grunt or Gulp. Not a deal-breaker, just extra work that may not be necessary :)

[adidahiya]

If you are consuming the library via Bower and point it to a github URL for this repo, Bower is not able to find one of the main entries, jquery.dropdown.css.

Also, not all users want to use Less for development...

[claviska]

If you are consuming the library via Bower and point it to a github URL for this repo, Bower is not able to find one of the main entries, jquery.dropdown.css.

Then the correct fix is to update bower.json.

Also, not all users want to use Less for development...

You don't have to. If you're using this plugin you're probably going to customize its appearance in some way. Good practice prevents us from modifying third party libraries, so we have a few options:

1. Don't modify it and use the library as-is (with default styles)
2. Import the default styles and override them as needed (use pure CSS or whatever preprocessor you want)
3. Copy the entire Less/CSS into your own source files and make your changes there (not recommended, but technically an option; in this case compile it manually or unminify using DirtyMarkup or similar)

If you're modifying the library itself, consider that your changes will be lost when you update. You should probably use one of the above methods instead :)

[adidahiya]

We don't want to modify the library ourselves; we want it to be pulled in and periodically updated via Bower.

We want to import the default styles file, jquery.dropdown.css into our app and apply overrides to customize it in another CSS file (I guess that's approach 2 in your comment). It's nice to have the unminified default styles file so that you can use it for debugging during development. We concatenate & minify all our CSS together (including 3rd party libs like jquery-dropdown) at the end for deployment so we have no use for jquery.dropdown.min.css.

[claviska]

Gotcha. I'd be more open to providing the unminified version instead (it's not much bigger anyways). Of course, that would constitute a breaking change and require a version bump. The only reason it comes minified is because that was the setting at the time.

[adidahiya]

This PR as it stands isn't a breaking change; it just fixes git URL consumption for Bower. You'd just have two versions of the usable CSS in your repo, minified and unminified. I think this is a good thing actually; users who want the minified version can use bower/wiredep overrides to get the the .min.css (which already exists in the downloaded package).

[claviska]

Also fixes #109.