soundasleep / jquery-dropdown

Bootstrap-style dropdowns with some added features and no dependencies.
Other
767 stars 266 forks source link

Namespace collision with Bootstrap #11

Closed briatx closed 11 years ago

briatx commented 11 years ago

There's a namespace collision with this plugin and bootstrap dropdowns. Both try to extend $.fn.dropdown in jquery. End result is that all bootstrap dropdowns stop working after one of the jquery-dropdowns is clicked.

I fixed it by renaming everything called 'dropdown' in this project to 'jq_dropdown'.

claviska commented 11 years ago

Fair enough, but this is intended for those who aren't or don't want to use bootstrap. What's your use-case for requiring both in the same app?

briatx commented 11 years ago

Yeah, it does seem a bit odd, huh.

I went with jquery-dropdown for certain controls because it handled embedding of form elements (particularly checkboxes) correctly. Bootstrap dropdowns would close even if clicking a checkbox... which is not optimal behavior.

But the site itself was based off of Bootstrap. I tried to replace some of the bootstrap dropdowns with jquery-dropdown (mainly the user menu in the navbar) and that didn't work either. So I ended up having to track down the namespace collision and fix it.

Anyway, just wanted to record it in case other people had similar problems.

Calaelen commented 11 years ago

Your Dropdown is a very good "addon" for the bootstrap framework - mainly because of the Select Box feature. Bootstrap can only display a big multiselect box without a dropdown :-(

laurentdebricon commented 11 years ago

too bad for the collision. Also, even after some renaming , using jquery-dropdown , then trying to trigger a bootstrap dropdown doesn't work anymore.

OndraM commented 11 years ago

I'd also like to use this plugin in bootstrap based project. The reasons are above... And I guess create own namespace isn't such a problem :-/.

OndraM commented 11 years ago

For those interested, I've created an fork, changing namespace to jqdropdown. Now it works just fine. Feel free to get it here: https://github.com/OndraM/jquery-dropdown