soundasleep / jquery-dropdown

Bootstrap-style dropdowns with some added features and no dependencies.
Other
767 stars 268 forks source link

Scss implementation #110

Closed sg1303 closed 8 years ago

sg1303 commented 8 years ago

What do you think about having an scss file in the project as well for those whose projects only use sass?

claviska commented 8 years ago

My newest project is using Sass too. I'll accept a PR if you want to do the [relatively simple] conversion :)

sg1303 commented 8 years ago

Done! https://github.com/claviska/jquery-dropdown/pull/111

sg1303 commented 8 years ago

Did you prefer to have both less and sass? I think I read your wording "conversion" meaning to completely convert. I can add the less file back too if you want.

claviska commented 8 years ago

Should have clarified...let's leave the Less version there until the next major version to prevent a breaking change. I'll update the Sass file as needed until then :)

sg1303 commented 8 years ago

OK, I went ahead and added that back and updated the codekit config file. Please take a look.