Use webpack for build; require in jquery.dropdown.sass as part of plugin

soundasleep / jquery-dropdown

Bootstrap-style dropdowns with some added features and no dependencies.

Other

765 stars 265 forks source link

Use webpack for build; require in jquery.dropdown.sass as part of plugin #116

Closed icenine457 closed 7 years ago

icenine457 commented 7 years ago

Wasn't sure what build system was being used prior to this commit, but I've introduced @Webpack in this commit as a means to bundle the CSS (compiled from the Sass file), as well as minifying. Since this is a pretty significant change, I'm happy to have this pull request be dismissed, but I had found it useful as it enabled me to not worry about including both the CSS and Javascript when using the plugin.

Also, great work on this! It's simple and straightforward to use.

claviska commented 7 years ago

Thanks for submitting this. I haven't played with Webpack yet, so I'm reluctant to start using it before I'm comfortable with it. This plugin definitely needs a better-defined build process, so it will either be this or a Gulp task. I'll leave this PR open for evaluation.

claviska commented 7 years ago

Decided to go with a Gulp task for this. Personal preference really. Follow #118 for progress.