search

soundasleep / jquery-dropdown

Bootstrap-style dropdowns with some added features and no dependencies.
Other
767 stars 268 forks source link

Support for Submenus #123

Open mjgood opened 7 years ago

mjgood commented 7 years ago

I needed to make some submenus for a project I'm working on. Didn't feel like updating all the menu references to another dropdown menu plugin, so I added support for submenus to this one.

claviska commented 7 years ago

I don't personally have any interest in submenus, but obviously some people do. Are you interested in creating an official fork of this project?

I'm asking because I don't use it anymore, so it doesn't get the attention it needs. (It could really use a rework tbh).

I'd hate to see your hard work collect dust, but I'm also not really excited about accepting vairous PRs and trying to support them longterm.

mjgood commented 7 years ago

Yeah, I'd be very okay managing a fork of the project for anyone else who was interested in submenus. While they're working fine for what I'm doing, there did seem to be places where people added in functionality that I didn't test (such as the if(!hideEvent.isDefaultPrevented()) condition), and while I believe it should still work, it wouldn't surprise me if issues manifested themselves that didn't exist in two or three test cases I put together that would still work just fine with the master branch.

This is kinda the first time I've made a contribution to an open-source community project like this... What all should I do as the manager of a fork for your project? It's a bit unlikely that I'll go through and rework the project anytime in the near future (although I do agree that there were a few things in the code that seemed odd or that may be redundant at this point), but I can definitely keep an eye for pull requests and questions, and I can make sure it remains backward-compatible with the master branch. Are there any naming conventions I should follow for the fork? Right now I have it called child-menus-mjgood because I was the only one working on the branch... should I rename it to something like jquery-dropdown-submenus or something?

On Fri, Mar 31, 2017 at 9:46 AM, Cory LaViska notifications@github.com wrote:

I don't personally have any interest in submenus, but obviously some people do. Are you interested in creating an official fork of this project?

I'm asking because I don't use it anymore, so it doesn't get the attention it needs. (It could really use a rework tbh).

I'd hate to see your hard work collect dust, but I'm also not really excited about accepting vairous PRs and trying to support them longterm.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/claviska/jquery-dropdown/pull/123#issuecomment-290716267, or mute the thread https://github.com/notifications/unsubscribe-auth/AOeHLCJhDJ7NleH7EXXqCgxOfGeZav0Zks5rrQOkgaJpZM4MulbE .

claviska commented 7 years ago

It's really up to you. If you want to maintain a separate fork, send a PR adding a link to the readme so people can find it. 😀

If anyone is up for adopting this project, please get in touch. It's been around for quite some time and has a lot of users, but my focus is on other projects at this time.

mjgood commented 7 years ago

Gotcha... I'll rename the fork and add a piece to the documentation sometime tomorrow and then shoot another pull request. I'll let you know if I hear of anyone interested, although things seem to be going more in the direction of GUI components built with React.js from what my understanding is... I'll let you know if anyone gets in touch with me who seems like a good fit for adopting the project though.

On Sat, Apr 1, 2017 at 8:22 PM, Cory LaViska notifications@github.com wrote:

It's really up to you. If you want to maintain a separate fork, send a PR adding a link to the readme so people can find it. 😀

If anyone is up for adopting this project, please get in touch. It's been around for quite some time and has a lot of users, but my focus is on other projects at this time.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/claviska/jquery-dropdown/pull/123#issuecomment-290956117, or mute the thread https://github.com/notifications/unsubscribe-auth/AOeHLDMlSnJSZXdNzM9Buz4oXSnEGS5cks5rrupegaJpZM4MulbE .