Remove duplicated bit of code

soundasleep / jquery-dropdown

Bootstrap-style dropdowns with some added features and no dependencies.

Other

767 stars 268 forks source link

Open eoghanmurray opened 6 years ago

eoghanmurray commented 6 years ago

I think this was a copy/paste error in https://github.com/soundasleep/jquery-dropdown/commit/bd607d001bc0a2470b4a385bc4df575502eaa49d but I'm not 100% so opening pull request for discussion.

Anyone know how I might ask @duizendnegen (the author)?

duizendnegen commented 6 years ago

:-1: this is not duplicate, it doesn't execute the event, only runs the trigger - so it might be cancelled by elements higher up the DOM.

eoghanmurray commented 6 years ago

Hmmm, are you talking about the call to jQuery.Event("hide"), because I'm not proposing removing that. This screenshot should better illustrate the potentially duplicated code I'm talking about: http://www.awesomescreenshot.com/image/2781882/9ec5a15cb7313fed6b7a83f1ab586352