search

soundasleep / jquery-dropdown

Bootstrap-style dropdowns with some added features and no dependencies.
Other
767 stars 268 forks source link

firefox dropdown position #51

Closed ghost closed 10 years ago

ghost commented 10 years ago

This is an amazing dropdown! Thanks for your support on making this. I have one issue though.

In safari and chrome my dropdown position is where I planned on it being, however in firefox, it goes off the right side. Anyone have issues with this that they've fixed?

Here is an example: http://jsfiddle.net/25E6w/5/

claviska commented 10 years ago

Works for me in Chrome. What browser are you using?

On Sunday, December 8, 2013 at 6:57 PM, bryangoldberg wrote:

I have 2 div elements that have a float:left inside my trigger. Showing the dropdown works fine when clicked. But if clicked again, it doesn't hide the dropdown anymore. When I remove the float:left, it works. Anyone have a fix for this? Here is an example: http://jsfiddle.net/25E6w/5/

— Reply to this email directly or view it on GitHub (https://github.com/claviska/jquery-dropdown/issues/51).

ghost commented 10 years ago

I updated my problem. It's Firefox I'm having trouble with

On Dec 8, 2013, at 10:09 PM, Cory LaViska notifications@github.com wrote:

Works for me in Chrome. What browser are you using?

On Sunday, December 8, 2013 at 6:57 PM, bryangoldberg wrote:

I have 2 div elements that have a float:left inside my trigger. Showing the dropdown works fine when clicked. But if clicked again, it doesn't hide the dropdown anymore. When I remove the float:left, it works. Anyone have a fix for this? Here is an example: http://jsfiddle.net/25E6w/5/

— Reply to this email directly or view it on GitHub (https://github.com/claviska/jquery-dropdown/issues/51).

— Reply to this email directly or view it on GitHub.

goosechaser commented 10 years ago

Any update on this?

amoswright commented 10 years ago

I was having a similar issue, though more widely (other browsers too). When the dropdowns were within certain other elements, the position was offset oddly. Changing the css of the .dropdown class from position:absolute; to position:fixed; seems to be helping. I'm still testing, but, wondering if this might help and/or if there are ramifications of this change that I haven't adequately considered?

claviska commented 10 years ago

@amoswright I think your fixed solution would cause problems when users scroll.

@bryangoldberg I tried swapping out the CSS in your Fiddle with the default stylesheet that comes with the plugin and it works fine in Firefox. I don't think it's a problem with the plugin, but perhaps the way it's being implemented. If you can narrow it down to something in the plugin, I'll be happy to accept a pull request or look at it further.

amoswright commented 10 years ago

Haha of course! Now I feel like a looser... Thanks for the quick reply, back to a proper fix... Best, Amos

On Mon, Jan 6, 2014 at 12:53 PM, Cory LaViska notifications@github.comwrote:

Closed #51 https://github.com/claviska/jquery-dropdown/issues/51.

— Reply to this email directly or view it on GitHubhttps://github.com/claviska/jquery-dropdown/issues/51 .