search

soundasleep / jquery-dropdown

Bootstrap-style dropdowns with some added features and no dependencies.
Other
767 stars 268 forks source link

Renamed CSS classes. #72

Closed bartvanderwal closed 9 years ago

bartvanderwal commented 9 years ago

Hi @claviska,

Can you review these changes? Both in the .css and .js ofcourse from dropdown to jq-dropdown and for JS variables jqDropdown (e.g. the 'camelCase' variant of the CSS kebab case :D).

claviska commented 9 years ago

Looks pretty good, but I can't accept as-is without index.html being updated. I can probably do it later this week if you don't want to.

Also, this is a breaking change so we'll have to mark it as 2.0.0 in bower.json/component.json :)

bartvanderwal commented 9 years ago

Hi @claviska,

I can look at updating index.html tomorrow. And test if everything works.

I guess this is pretty breaking indeed, thought funtionally ofcourse nothing should change.

claviska commented 9 years ago

This was fixed comprehensively in 2.0.0.