soundcloud / chunk-manifest-webpack-plugin

Allows exporting a manifest that maps entry chunk names to their output files, instead of keeping the mapping inside the webpack bootstrap.
MIT License
394 stars 73 forks source link

Why is _.replace used if no string parameter is specified? #57

Closed qikevinjkw closed 6 years ago

qikevinjkw commented 6 years ago

See https://github.com/soundcloud/chunk-manifest-webpack-plugin/blob/master/lib/ChunkManifestPlugin.js#L55 The _.replace() is called with just two parameters, which just returns the first one according to lodash's doc https://github.com/lodash/lodash/blob/d10b44bdef2b735865c493fbaec8687ec8998aef/replace.js.

Is there a reason for using _.replace like this? Why not just return "__CHUNK_MANIFEST__".

qikevinjkw commented 6 years ago

_ is not referring to lodash...