search

soundcloud / lhm

Online MySQL schema migrations
BSD 3-Clause "New" or "Revised" License
1.83k stars 190 forks source link

Moved to date_source_exist from table_exists #145

Open nikoatwork opened 7 years ago

nikoatwork commented 7 years ago

As of this change in Rails (https://github.com/rails/rails/pull/21601) the #table_exists? should be replaced by #data_source_exists?

There was already an open issue for this matter: https://github.com/soundcloud/lhm/issues/144

grobie commented 7 years ago

Which versions of ActiveRecord support that?

moonzez commented 7 years ago

date_source_exists? is available since the rails version 4.2.7 https://apidock.com/rails/v4.2.7/ActiveRecord/ConnectionAdapters/SchemaStatements/data_source_exists%3F

nikoatwork commented 7 years ago

@grobie Is there any way i can contribute to get this merged?

grobie commented 7 years ago

@nikonoll so the issue is that there are known users who are stuck on Rais 2.3. I haven't worked with LHM in a while though. It could be an option to force them to use an older version of LHM.

nikoatwork commented 7 years ago

@grobie Okay, thanks for letting me know. Is there any official status of this gem concerning it being maintained actively and kept up to date? For us it would be great to know weather we should stick to LHM in general.

grobie commented 7 years ago

@nikonoll At SoundCloud we mostly use Percona's online-schema-change tool now.

grobie commented 7 years ago

There were some active contributors to LHM and I'd be happy to add someone as collaborator if they want to step up and take over maintainership.

nikoatwork commented 7 years ago

@grobie Thanks for the info