search

soundcloud / lhm

Online MySQL schema migrations
BSD 3-Clause "New" or "Revised" License
1.83k stars 190 forks source link

Change schema validation to match actual requirement #92

Closed hannestyden closed 9 years ago

hannestyden commented 9 years ago

The Chunker requires an auto incrementing integer column called id to successfully chunk the table while migrating.

hannestyden commented 9 years ago

CI builds failed intermittently due to a timing issue and losing connection to the database. Does anyone know how to alleviate those problems? Thanks. :bow:

bjk-soundcloud commented 9 years ago

@hannestyden I triggered a rebuild on Travis. All good now

bjk-soundcloud commented 9 years ago

:+1:

hannestyden commented 9 years ago

@bjk-soundcloud Thanks a bunch! :bow:

hannestyden commented 9 years ago

For some reason all records are not being migrated when the id column is not PRIMARY KEY even if the Table#pk extracted by Parser#extract_primary_key seems to be ignored by Chunker. Have to investigate more to figure out why.

hannestyden commented 9 years ago

False alarm! My test was borked somehow.

The seemingly unused Parser#extract_primary_key still worries me though. :worried:

hannestyden commented 9 years ago

Cleaned up the tests and rebased.

Please review again. :bow:

/cc @bjk-soundcloud

bjk-soundcloud commented 9 years ago

Fantastic, thanks! :+1:

arthurnn commented 9 years ago

Add a changelog https://github.com/soundcloud/lhm/commit/771821caec22e3edd2e17e81427e0d1cd9040abf thanks all.